Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbuffer: add gcc to LD_LIBRARY_PATH #213464

Closed
wants to merge 1 commit into from
Closed

mbuffer: add gcc to LD_LIBRARY_PATH #213464

wants to merge 1 commit into from

Conversation

Majiir
Copy link
Contributor

@Majiir Majiir commented Jan 29, 2023 •
edited
Loading

Description of changes

Fixes #213453. mbuffer needs libgcc_s.so.1 when it's cross-compiled.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross)
    • armv7l-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from tokudan January 29, 2023 23:06
@tokudan
Copy link
Contributor

tokudan commented May 6, 2023

I've been busy with other things the last months and don't have any knowledge about compilation and linking, so I'm unable to tell if this is going to fix #213453 and if it's the right solution.
If it works, it's probably better than ignoring the issue.

@ghost
Copy link

ghost commented Jun 29, 2023

I think #238154 will fix this. Let's not use LD_LIBRARY_PATH unless we get really really desperate.

@Majiir Majiir mentioned this pull request Jul 14, 2023
Merged
12 tasks
@Majiir
Copy link
Contributor Author

Majiir commented Aug 15, 2023

Issue resolved by a different PR.

@Majiir Majiir closed this Aug 15, 2023
@ghost
Copy link

ghost commented Aug 16, 2023 •
edited by ghost
Loading

Issue resolved by a different PR.

Specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokudan tokudan Awaiting requested review from tokudan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mbuffer: cross-compiled libgcc_s.so.1 must be built with glibc headers for pthread_cleanup_push() to work
2 participants
@Majiir @tokudan